[ZendTo] LDAP authentication broken after 6.05-2 upgrade

[Etienne Vogt]

On Mon, 31 Aug 2020, Etienne Vogt via ZendTo wrote:

> I've just upgraded ZendTo to the last 6.05-2 and LDAP authentication
> no longer works. Our users get a blank page and we get the following
> PHP error message in /var/log/apache2/zendto_error.log (real login
> and password replaced with fake ones) :
>
> [Mon Aug 31 18:23:25.035288 2020] [php7:error] [pid 31732] [client 
> 145.238.184.196:33360] PHP Fatal error:  Uncaught ArgumentCountError: Too few 
> arguments to function NSSAuthenticator::authenticate(), 3 passed in 
> /opt/zendto/lib/NSSLDAPAuthenticator.php on line 392 and exactly 4 expected 
> in /opt/zendto/lib/NSSAuthenticator.php:165\nStack trace:\n#0 
> /opt/zendto/lib/NSSLDAPAuthenticator.php(392): 
> NSSAuthenticator->authenticate('login', 'password', Array)\n#1 
> /opt/zendto/lib/NSSMultiAuthenticator.php(154): 
> NSSLDAPAuthenticator->authenticate('login', 'password', Array, '')\n#2 
> /opt/zendto/lib/NSSDropbox.php(2332): 
> NSSMultiAuthenticator->authenticate('login', 'password', Array, '')\n#3 
> /opt/zendto/lib/NSSDropbox.php(620): NSSDropbox->userFromAuthentication()\n#4 
> /opt/zendto/www/index.php(35): NSSDropbox->__construct(Array)\n#5 {main}\n 
> thrown in /opt/zendto/lib/NSSAuthenticator.php on line 165
>
> We are running ZendTo on a Debian 10 LXC container.

Here's a quick and dirty patch that seems to correct the problem :

--- /opt/zendto/lib/NSSLDAPAuthenticator.php~	2020-08-13 13:49:42.000000000 +0200
+++ /opt/zendto/lib/NSSLDAPAuthenticator.php	2020-08-31 18:45:11.319698698 +0200
@@ -389,7 +389,7 @@
              }
              //  Chain to the super class for any further properties to be added
              //  to the $response array:
-            parent::authenticate($uname,$password,$response);
+            parent::authenticate($uname,$password,$response,$errormsg);
            }
          }
        }

-- 
 		Etienne Vogt (Etienne.Vogt at obspm.fr)
 		Observatoire de Paris-Meudon
 		Service Informatique