[ZendTo] Minor javascript defect

[Bocquet Stéphane]

Hi John,

Even if I will not use it (I'm on, Debian with no reverse-proxy), thanks for the patch. ;)

Cheers,

-----Message d'origine-----
De : zendto-bounces at zend.to [mailto:zendto-bounces at zend.to] De la part de John Thurston
Envoyé : mardi 13 mars 2018 20:24
À : zendto at zend.to
Objet : Re: [ZendTo] Minor javascript defect

I've created a patch file for this mod, and am posting it here for future reference . . . assuming this list accepts attachments.

On CentOS 7, from /opt/zendto

# patch -b -p0 -i main.js.patch

--
    Do things because you should, not just because you can.

John Thurston    907-465-8591
John.Thurston at alaska.gov
Department of Administration
State of Alaska

On 3/8/2018 2:07 PM, John Thurston wrote:
> The "Add Recipients" pop-up box asks for
>    /js/facebox/closelabel.png
>    /js/facebox/loading.gif
> 
> These absolute paths work ok if you are serving your content directly 
> from the local apache (and /js is published). I'm serving my content 
> with a reverse-proxy server, and those images fail to load because /js 
> isn't the root of the application so isn't proxied.
> 
> I've gotten correct behavior by editing
>    /opt/zendto/www/js/main.js
> and removing the leading slash from those file names at the bottom of 
> the file, making them relative references:
> 
>> /* Setup Facebox */
>> $.facebox.settings.closeImage = 'js/facebox/closelabel.png'
>> $.facebox.settings.loadingImage = 'js/facebox/loading.gif'
> 
> Does such a patch break the application for anyone else?
> Is this appropriate to roll into the next rev so I don't need to make 
> a local patch-file and re-apply on my updates?